Skip to content

Minor formatting fixes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2024
Merged

Minor formatting fixes #2

merged 3 commits into from
Aug 28, 2024

Conversation

BenCuff
Copy link
Contributor

@BenCuff BenCuff commented Aug 28, 2024

Made the following changes:

  1. In "contributing.md", added a subject line to the email link, as per other similar links
  2. In "quality-assurance.md", added line breaks between some guidance links in the tables (this doesn't show up so well in the commit diffs below, but you can see additional "<br><br>" in between links)
  3. In "rap-framework.md", removed the reference to the UKHSA cookiecutter tool (which seems to now be private)

I have tested these changes in Ruby and confirmed they look ok.

@BenCuff BenCuff requested a review from hollygoss August 28, 2024 12:52
hollygoss
hollygoss approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@hollygoss hollygoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes - code checked. Approved.

@hollygoss hollygoss merged commit 3bf8e67 into main Aug 28, 2024
@hollygoss hollygoss deleted the bc-minor-fixes branch August 28, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hollygoss hollygoss hollygoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenCuff @hollygoss